Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Clipboard confirm delete labels #18183

Merged
merged 17 commits into from
Jan 31, 2025

Conversation

madsrasmussen
Copy link
Contributor

@madsrasmussen madsrasmussen commented Jan 30, 2025

Fixes #18168

This PR makes it possible to override the default headline and content labels in the delete dialog.

I have updated the .string() method to take in args the same way as the .term() method. If a sting consists of multiple translation keys then the same args will be sent to all keys.

Ex:

this.localize.string('#greeting', 'Person 1');

The dialog after the update
Screenshot 2025-01-30 at 23 21 40

@madsrasmussen madsrasmussen changed the title Hotfix: Clipboard delete confirm labels Hotfix: Clipboard confirm delete labels Jan 30, 2025
@madsrasmussen madsrasmussen marked this pull request as ready for review January 30, 2025 22:02
@madsrasmussen madsrasmussen added the category/ux User experience label Jan 31, 2025
@nul800sebastiaan nul800sebastiaan linked an issue Jan 31, 2025 that may be closed by this pull request
@nielslyngsoe nielslyngsoe merged commit d4cfe4d into release/15.2 Jan 31, 2025
29 checks passed
@nielslyngsoe nielslyngsoe deleted the 15.2/hotfix/clipboard-delete-confirm-dialog branch January 31, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V15.2 Clipboard delete is ambiguous
2 participants